Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added last_changed column to PacBio metrics tables #222

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Added last_changed column to PacBio metrics tables #222

merged 2 commits into from
Oct 24, 2023

Conversation

mgcam
Copy link
Member

@mgcam mgcam commented Oct 23, 2023

Also updated the ORM

mgcam added 2 commits October 23, 2023 16:41
@mgcam
Updated DBIx classes from the prod database schema.
5000a6d 
Two types of changes:
  1. due to a aserver upgrade tp MySQL v.8+
  2. due to database schema changes.
@mgcam
Added last_changed column to pac_bio_*_metrics.
ee52bda 
Added `last_changed` column to `pac_bio_run_well_metrics`
and `pac_bio_product_metrics` tables.
@mgcam mgcam requested a review from ces October 23, 2023 15:51
nerdstrike
nerdstrike reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@nerdstrike nerdstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of changes, a bit confused by the release in the changelog, as I thought these happened independently

@nerdstrike nerdstrike merged commit 6dcd5b6 into wtsi-npg:devel Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdstrike nerdstrike nerdstrike approved these changes

@ces ces Awaiting requested review from ces

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgcam @nerdstrike